Unable to import cocktails in Bar Assistant V4

[rosschurchill]

Hey folks

I'm encountering issues with importing cocktails in Bar Assistant V4. I was previously able to import cocktails in the last version, although I had some issues with image imports. Now, with V4, I'm unable to successfully import cocktails at all. Here are the details:

1. Current Setup:

   • Bar Assistant Version: V4 (please specify the exact version if known)
   • API Base URL: http://MYIP:8081/bar/api
   • Environment: (Docker)

2. Issue Description:

   • Unable to import cocktails using the /import/cocktails endpoint
   • Receiving a 500 Internal Server Error when attempting to import

3. What I've Tried:

   • Successfully created ingredients using the /ingredients endpoint
   • Attempted to create cocktails directly and through the import endpoint
   • Simplified the cocktail data to minimal required fields

4. Script Used:

#!/bin/bash
# Load environment variables
source .env
# API configuration
API_BASE_URL="${BAR_ASSISTANT_API_URL}"
API_TOKEN="${BAR_ASSISTANT_API_TOKEN}"
BAR_ID="${BAR_ASSISTANT_BAR_ID:-1}"
# Simple cocktail data
COCKTAIL_JSON='{
  "name": "Test Cocktail",
  "instructions": "Mix all ingredients and serve.",
  "description": "A simple test cocktail",
  "ingredients": [
    {
      "ingredient_id": 193,
      "amount": 50,
      "units": "ml"
    }
  ]
}'
# Function to create a cocktail
create_cocktail() {
    local create_url="${API_BASE_URL}/import/cocktails?type=yaml&bar_id=1"
    echo "Creating test cocktail"
    echo "Using API URL: $create_url"
    
    echo "Request Payload:"
    echo "$COCKTAIL_JSON" | jq .
    echo "Sending request..."
    response=$(curl -s -w "\n%{http_code}" -X POST "$create_url" \
        -H "Authorization: Bearer $API_TOKEN" \
        -H "Accept: application/json" \
        -H "Content-Type: application/json" \
        -H "Bar-Assistant-Bar-Id: $BAR_ID" \
        -d "$COCKTAIL_JSON")
    http_status=$(echo "$response" | tail -n1)
    response_body=$(echo "$response" | sed '$d')
    echo "HTTP Status: $http_status"
    echo "Response Body:"
    echo "$response_body" | jq . || echo "$response_body"
    if [[ "$http_status" == "201" || "$http_status" == "200" ]]; then
        echo "Successfully created cocktail"
        return 0
    else
        echo "Failed to create cocktail. See the response above for details."
        return 1
    fi
}
# Main script
create_cocktail
if [ $? -eq 0 ]; then
    echo "Cocktail creation process completed successfully."
else
    echo "Cocktail creation process failed."
fi

5. Observations:

   • The script successfully connects to the API (as evidenced by successful ingredient creation)
   • The cocktail import endpoint returns a 500 Internal Server Error
   • No detailed error message is provided in the response

6. Questions:

   • Are there any known issues with cocktail imports in V4?
   • Has the import endpoint or required format changed significantly from the previous version?
   • Are there any specific server-side logs I should check for more detailed error information?

7. Additional Information:

   • I can successfully create ingredients through the API
   • The server responds to other API endpoints without issues
   • I've verified that the API token and Bar ID are correct

Any guidance on resolving this issue or suggestions for further troubleshooting would be greatly appreciated. Please let me know if you need any additional information or if there are specific tests I can run to provide more details.

Thank you for your assistance!

Ross

[zhdenny]

For what it's worth, I'm using latest versions of Saltrim and BarAssistant.... I've successfully imported cocktails from Punch website as recently as today... But not using any fancy scripts... Just the SaltRim GUI

[karlomikus]

Hello.

Detailed logs should be in your docker logs.

Import and scrape endpoints got changed recently, import endpoint expects the source data in a valid JSON schema. You can check the most recent docs if you visit {api_url}/docs.

[rosschurchill]

Thanks of the reply

I can't seem to get that docs library to open i can get a response from {api_url}/server/version how ever

Is this URL up to date https://api.barassistant.app/docs#/ ?

Regards
R

[karlomikus]

Yes, those are up to date with v4