data.files is replaced

[bkrrrr]

It seems like its not possible right now to use files in options and another target. Or at least the output is not as expected.

What is the idea behind that block (grunt-karma.js:74)?

    if (data.files || options.files) {
      data.files = [].concat.apply(options.files || [], this.files.map(function (file) {
        return file.src.map(function (src) {
          var obj = {
            pattern: src
          }
          var opts = ['watched', 'served', 'included']
          opts.forEach(function (opt) {
            if (opt in file) {
              obj[opt] = file[opt]
            }
          })
          return obj
        })
      }))
      data.files = _.flattenDeep(data.files)
    }

by replacing this with:

if (data.files || options.files) {   
      data.files = data.files || [];
      if(options.files){
        data.files = data.files.concat(options.files)
      }
 }

files is usable as expected

[Krinkle]

@bkrrrr I investigated the issue and I understand the code now. However, just as you, I also thought it was a mistake.

The code looks like it is forgetting to add the contents of data.files. But, I understand it now.

The data.files key of the task data, cannot be used directly. It must be processed and expanded by Grunt internally. The processed version is available to the Grunt plugin as this.files. As such, no information is lost. It is working as expected.