Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

module error in go.mod #2834

Closed
lhmily opened this issue Jul 16, 2020 · 7 comments
Closed

module error in go.mod #2834

lhmily opened this issue Jul 16, 2020 · 7 comments
Labels
bug Incorrect behaviour needs-more-info Blocked until user or author provides further details

Comments

@lhmily
Copy link

lhmily commented Jul 16, 2020

Description of problem

(replace this text with the list of steps you followed)
image
image

Expected result

module github.com/kata-containers/runtime/virtcontainers/pkg/cloud-hypervisor/client

Actual result

module github.com/GIT_USER_ID/GIT_REPO_ID

@lhmily lhmily added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Jul 16, 2020
@ariel-adam
Copy link

@lhmily Can you please provide more information on what is the problem you are seeing?
What is the expected behavior vs the actual behavior?
Why do you think this is a kata issue and not a cloud hypervisor issue?

@jodh-intel
Copy link
Contributor

Do you have any input on this @rbradford, @sboeuf?

@jodh-intel jodh-intel added needs-more-info Blocked until user or author provides further details bug Incorrect behaviour needs-review Needs to be assessed by the team. and removed bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Sep 8, 2020
@rbradford
Copy link
Contributor

@jodh-intel
Copy link
Contributor

@jcvenegas ^^

@jodh-intel
Copy link
Contributor

We don't use go modules with Kata 1.x, but we do for Kata 2.0 (added on kata-containers/kata-containers@e540648 as part of kata-containers/kata-containers#199).

Interestingly, although we use go.mod for 2.0, this virtcontainers/pkg/cloud-hypervisor/client/go.mod file does not exist in 2.0:

... so maybe this file should never have been added to this repo?

@bergwolf - do you know anything about this?

Finally, there is an issue to port Kata 1.x to use go mod: #1331.

@jodh-intel
Copy link
Contributor

So, is the solution to simply remove the go.mod file from this repo?

@jodh-intel jodh-intel removed the needs-review Needs to be assessed by the team. label Sep 15, 2020
@fidencio
Copy link
Member


This issue is being automatically closed as Kata Containers 1.x has now reached EOL (End of Life). This means it is no longer being maintained.

Important:

All users should switch to the latest Kata Containers 2.x release to ensure they are using a maintained release that contains the latest security fixes, performance improvements and new features.

This decision was discussed by the @kata-containers/architecture-committee and has been announced via the Kata Containers mailing list:

If you believe this issue still applies to Kata Containers 2.x, please open an issue against the Kata Containers 2.x repository, pointing to this one, providing details to allow us to migrate it.


Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Incorrect behaviour needs-more-info Blocked until user or author provides further details
Projects
None yet
Development

No branches or pull requests

5 participants