DATAUP-727: Fix an import spec parse bug re trailing separators #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an xSV file is opened and saved by Excel, it'll add trailing separators to the end of the first header line. This fix ignores those separators.
|
I don't know what the heck is going on with the tests, they pass locally and the test that is failing is saying an ascii file that the tests write isn't a text file. I'm using the same function to write other files so this is odd. |
|
This pull request introduces 1 alert when merging 527cb8a into f0777a4 - view on LGTM.com new alerts:
|
|
I get a failure locally |
Not quite sure why tests were passing everywhere up till now, or why tests pass locally - maybe a `magic` update
|
@bio-boris ok, looks fixed |
... maybe? Tests still don't pass on Boris's machine, this might fix it
|
Kudos, SonarCloud Quality Gate passed!
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an xSV file is opened and saved by Excel, it'll add trailing separators to
the end of the first header line. This fix ignores those separators.