Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.3.4 #173

Merged
merged 7 commits into from
May 2, 2022
Merged

Release v1.3.4 #173

merged 7 commits into from
May 2, 2022

Conversation

MrCreosote
Copy link
Member

No description provided.

MrCreosote and others added 7 commits March 11, 2022 10:36
* Fix a import spec parse bug re trailing separators

If an xSV file is opened and saved by Excel, it'll add trailing separators to
the end of the first header line. This fix ignores those separators.

* Bump version, add release notes

* Fix unused import

* Provide more info if a file isn't an expected type

* Add csv file type to list of allowed files

Not quite sure why tests were passing everywhere up till now, or why
tests pass locally - maybe a `magic` update

* Remove redundant file type check

doh

* Fix tests on mac

... maybe? Tests still don't pass on Boris's machine, this might fix it
DATAUP-746: empty `types` dictionary throws an error
1.3.4 was never deployed to CI, let alone prod,, so no need for another
version bump
@MrCreosote MrCreosote requested a review from bio-boris April 28, 2022 20:28
@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@bio-boris bio-boris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrCreosote MrCreosote merged commit 795ea92 into master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants