-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace gradlization feature merge #739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle pt 1: tests + coverage
JNA doesn't work in a shadow jar, which we'll need for workspace test rigs in other repos
Remove JNA
The java common UObject class needs those links, but not the workspace docs
Build docs
Next step is to port the workspace controller from groups to use the shadow jar in a similar manner to auth, negating the need for the jars repo or a jars list
Tested in groups with the shadow jar. Needed some minor test changes but passed.
Add shadow jar and workspace controller that starts said jar
Build docker image with gradle
Build client jar
Tested with -h
Add schema updater script build
Also switch the default url to CI
Add kb-sdk compile tasks
Add git commit to status() method & build
Move source files to Gradle default locations
Also deleted a no longer relevant Shock warning. The documentation needs to be updated for Shock -> Blobstore all over the place, but that's another commit or two.
Javadocs link properly Also remove ServiceChecker, it's completely unused at this point
Update documentation for Gradle changes
Use jitpack jars and publish shadow jar
Make a gradle service module for the main server code
Add a workspace client module
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #739 +/- ##
=============================================
+ Coverage 87.66% 87.78% +0.11%
+ Complexity 5329 5328 -1
=============================================
Files 228 228
Lines 17648 17598 -50
Branches 2573 2585 +12
=============================================
- Hits 15471 15448 -23
+ Misses 1714 1694 -20
+ Partials 463 456 -7 |
ialarmedalien
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges all the already approved workspace Gradlization work to develop