Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Idea KCL Plugin Build on 233+ version including Ultimate and Community Edition #21

Closed
3 tasks
Peefy opened this issue Dec 27, 2023 · 5 comments
Assignees
Labels

Comments

@Peefy
Copy link
Contributor

Peefy commented Dec 27, 2023

  • Plugin Release 0.1.15 does not work on 232 Community Edition because of the deps https://github.com/kcl-lang/intellij-kcl/pull/12 in PR add kcl lsp #12

image

  • Plugin Release 0.1.5 does not work on 233+ version including Ultimate and Community Edition
  • LSP Features do not work on 232.2 Ultimate version
@Peefy Peefy added the release label Dec 27, 2023
@Peefy Peefy changed the title [Enhancement] Idea KCL Plugin Build on 233+ version [Enhancement] Idea KCL Plugin Build on 233+ version including Ultimate and Community Edition Dec 27, 2023
@alloveras
Copy link

alloveras commented Jan 24, 2024

Hello @Peefy,
I tried building the plugin for pluginUntilBuild = 233.* and platformVersion = 2023.3.2 from the main branch and it seems to work. I suspect this is because the lsp dependencies that you mention on the first bullet point in the issue description are in the lsp branch.

I wonder what's the plan to resolve the build failures on the lsp branch since JetBrains seems to make it very clear that LSP support will only be available in the paid versions of their IDEs (which effectively means: no Community Edition).

Thanks in advance!

@Peefy
Copy link
Contributor Author

Peefy commented Jan 24, 2024

ping @He1pa

@He1pa
Copy link
Contributor

He1pa commented Jan 24, 2024

Hello @Peefy, I tried the plugin for pluginUntilBuild = 233.* and platformVersion = 2023.3.2 from the main branch and it seems to work. I suspect this is because the lsp dependencies that you mention on the first bullet point in the issue description are in the lsp branch.

I wonder what's the plan to resolve the build failures on the lsp branch since JetBrains seems to make it very clear that LSP support will only be available in the paid versions of their IDEs (which effectively means: no Community Edition).

Thanks in advance!

You are right, the build failure problem occurs in the lsp branch. But I have fixed this problem and published a new version plugin in IDEA Marketplace. Now it's time to close this Issue. But anyway, thank you for your support.

@He1pa He1pa closed this as completed Jan 25, 2024
@alloveras
Copy link

Do you mind pointing me to where the new plugin version has been released?

I could not find it either in this repository releases list nor in the IntelliJ marketplace 😅?

@He1pa
Copy link
Contributor

He1pa commented Jan 25, 2024

Do you mind pointing me to where the new plugin version has been released?

I could not find it either in this repository releases list nor in the IntelliJ marketplace 😅?

you can build it from 'lsp' branch or search it from marketplace
https://plugins.jetbrains.com/plugin/23378-kcl
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants