Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Adds a Proxy for the download process of three-party dependent modules #526

Open
zong-zhe opened this issue Nov 8, 2024 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@zong-zhe
Copy link
Contributor

zong-zhe commented Nov 8, 2024

Feature Request

Is your feature request related to a problem? Please describe:

Support proxy mode to improve the stability and speed of the download process. Similar to the ability to set up proxies provided in go mod and cargo

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@zong-zhe zong-zhe added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 8, 2024
@inosmeet
Copy link

Hey @zong-zhe! I would like to try this one. Can you help me get started?

@ravjot07
Copy link

Hi @zong-zhe,

I would like to work on adding proxy support to our downloader module to enhance the download process of third-party dependencies, especially in environments that require proxy configurations. My approach involves introducing a ProxyURL option in our download settings and updating the relevant code to utilize this proxy setting throughout the download process.

By adding a ProxyURL field to our configuration structs and modifying the download methods to use custom HTTP clients with proxy settings, we can ensure that both Git and OCI downloads operate smoothly behind a proxy.

May I work on this issue to implement the proxy support as described?

@zong-zhe
Copy link
Contributor Author

Hi @inosmeet @ravjot07 😄

Welcome !

This job is in the very early stage of solving the problem of slow download speed caused by KCL being limited by network problems. You may need to learn more about project content and some proxy-related things first, refer to some existing programming language package management tools on the market, and minimize the problem of the task that needs to be done. Could you try provide a paperwork solution first ? 😄

@zong-zhe
Copy link
Contributor Author

Hi @ravjot07 😄

Thanks very much for your contribution, but we can move forward with this part of the work as planned. You don't have to rush with the code. First, we complete some necessary preparations through the paperwork solution. I will now close this PR: #547. You can add some paperwork solution PRs to this directory: https://github.com/kcl-lang/kpm/tree/main/research/design-doc.

@ravjot07
Copy link

Hi @ravjot07 😄

Thanks very much for your contribution, but we can move forward with this part of the work as planned. You don't have to rush with the code. First, we complete some necessary preparations through the paperwork solution. I will now close this PR: #547. You can add some paperwork solution PRs to this directory: https://github.com/kcl-lang/kpm/tree/main/research/design-doc.

Sure @zong-zhe I will add paperwork solution first......

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants