Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update PyO3 to 0.23.3 #273

Closed
feltroidprime opened this issue Dec 12, 2024 · 2 comments · Fixed by #275
Closed

feat: Update PyO3 to 0.23.3 #273

feltroidprime opened this issue Dec 12, 2024 · 2 comments · Fixed by #275
Assignees
@sigmadawg
Labels
enhancement Enhancement of the code, not introducing new features. help-wanted We need some extra helping hands or expertise in order to resolve this! rust Pull requests that update Rust code

Comments

@feltroidprime
Copy link
Collaborator

feltroidprime commented Dec 12, 2024 •
edited
Loading

Update dependencies of PyO3 in https://github.com/keep-starknet-strange/garaga/blob/main/tools/garaga_rs/Cargo.toml to version 0.23.3 and update code so that cargo build outputs no deprecation warnings.

See https://pyo3.rs/v0.23.0/migration.html
@feltroidprime feltroidprime added the enhancement Enhancement of the code, not introducing new features. label Dec 12, 2024
@feltroidprime feltroidprime changed the title feat: Update PyO3 to 23.3 feat: Update PyO3 to 0.23.3 Dec 12, 2024
@feltroidprime feltroidprime added help-wanted We need some extra helping hands or expertise in order to resolve this! rust Pull requests that update Rust code labels Dec 12, 2024
@sigmadawg
Copy link
Contributor

i want to solve this issue, can i take this up?

@feltroidprime
Copy link
Collaborator Author

yes

@sigmadawg sigmadawg mentioned this issue Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sigmadawg sigmadawg

Labels
enhancement Enhancement of the code, not introducing new features. help-wanted We need some extra helping hands or expertise in order to resolve this! rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump version sigmadawg/garaga
2 participants
@feltroidprime @sigmadawg