Skip to content
This repository has been archived by the owner on May 3, 2019. It is now read-only.

Invalid watchers count with transclude directives #4

Closed
shedar opened this issue Nov 3, 2014 · 7 comments
Closed

Invalid watchers count with transclude directives #4

shedar opened this issue Nov 3, 2014 · 7 comments

Comments

@shedar
Copy link

shedar commented Nov 3, 2014

Different nodes can share same scope. In this case ng-stats will count same watcher multiple times.
Following example has 20 watchers according to ng-stats, but actually just 8 (I added all watchers to array and filtered to unique values)
http://run.plnkr.co/plunks/KX2BPbbt47gYtEtcS6GR/

Plunker sources: http://plnkr.co/edit/KX2BPbbt47gYtEtcS6GR

@kentcdodds
Copy link
Owner

Wow, terrific find. Thanks! I'll look into fixing that.

@demisx
Copy link

demisx commented Nov 13, 2014

+1

@kentcdodds
Copy link
Owner

Apologies, I'll see about getting this fixed soon.

@demisx
Copy link

demisx commented Nov 13, 2014

No worries. Since Batarang development has been at a stall, we rely more and more on ng-inspector and ng-stats nowdays. Thank you for all your awesome work.

@kentcdodds
Copy link
Owner

I've republished to npm and bower with version 1.0.4 :-) Thanks!

@kentcdodds
Copy link
Owner

Oh, and never fear. Batarang will be released in brand new glory soon :-)

@demisx
Copy link

demisx commented Nov 13, 2014

Do I hope! Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants