Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new column - platform_ingest_timestamp_ns #25

Open
RuffSeason opened this issue Oct 18, 2023 · 2 comments
Open

Add new column - platform_ingest_timestamp_ns #25

RuffSeason opened this issue Oct 18, 2023 · 2 comments

Comments

@RuffSeason
Copy link

We need to add a new column to libkflow - platform_ingest_timestamp_ns.

@RuffSeason
Copy link
Author

@aaronfuj - is there really any reason for us to add this column to libkflow if this metric is really about Kentik's time of ingestion? I would imagine its much more important for us to add the plumbing for data_collection_time to libkflow no?

@aaronfuj
Copy link
Contributor

I agree that it is more important to add in data collection time. We should update the underlying generated proto file in either case to ensure there is less version drift but we don't need to hook it up with the Flow struct here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants