feat(core): throw an error if the secret is not found

kestra-io · Dec 17, 2024 · da1bbb5 · da1bbb5
1 parent b133210
commit da1bbb5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/core/src/main/java/io/kestra/core/secret/SecretService.java b/core/src/main/java/io/kestra/core/secret/SecretService.java
@@ -38,6 +38,10 @@ public void decode() {
     }
 
     public String findSecret(String tenantId, String namespace, String key) throws SecretNotFoundException, IOException {
-        return decodedSecrets.get(key.toUpperCase());
+        String secret = decodedSecrets.get(key.toUpperCase());
+        if (secret == null) {
+            throw new SecretNotFoundException("Cannot find secret for key '" + key + "'.");
+        }
+        return secret;
     }
 }
diff --git a/core/src/test/java/io/kestra/core/secret/SecretFunctionTest.java b/core/src/test/java/io/kestra/core/secret/SecretFunctionTest.java
@@ -23,6 +23,7 @@
 
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.*;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 @KestraTest
 public class SecretFunctionTest extends AbstractMemoryRunnerTest {
@@ -53,9 +54,9 @@ void getSecret() throws TimeoutException, QueueException {
     }
 
     @Test
-    void getUnknownSecret() throws IllegalVariableEvaluationException, IOException {
-        String secret = secretService.findSecret(null, null, "unknown_secret_key");
+    void getUnknownSecret() {
+        var exception = assertThrows(SecretNotFoundException.class, () -> secretService.findSecret(null, null, "unknown_secret_key"));
 
-        assertThat(secret, nullValue());
+        assertThat(exception.getMessage(), is("Cannot find secret for key 'unknown_secret_key'."));
     }
 }