Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new filters throughout the product #5984

Open
8 of 14 tasks
Tracked by #5845
MilosPaunovic opened this issue Nov 19, 2024 · 2 comments
Open
8 of 14 tasks
Tracked by #5845

Introduce new filters throughout the product #5984

MilosPaunovic opened this issue Nov 19, 2024 · 2 comments
Assignees
Labels
area/backend Needs backend code changes enhancement New feature or request

Comments

@MilosPaunovic
Copy link
Member

MilosPaunovic commented Nov 19, 2024

Replace usage of filters throughout the application & add missing filters.

List of places where we need the change:

  • Dashboard
  • Flows listing
  • Single flow, Overview
  • Single flow, Executions
  • Single flow, Logs
  • Single flow, Metrics
  • Single flow, Audit Logs (EE)
  • Executions listing
  • Single execution, Logs
  • Single execution, Audit Logs (EE)
  • Logs listing
  • Administration, Audit Logs (EE)
  • Administration, Triggers
  • Administration, Cluster, Services (EE)

@Ben8t Could you do another full sweep through the product to check if I missed any place where we should replace the old filtering system with the new one (make not that, for now, not using it if there is only the search field in place)?

@MilosPaunovic MilosPaunovic added area/backend Needs backend code changes enhancement New feature or request labels Nov 19, 2024
@MilosPaunovic MilosPaunovic self-assigned this Nov 19, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Nov 19, 2024
@MilosPaunovic
Copy link
Member Author

@Ben8t I've added new filtering system to all the checked pages from above. Could you test it to see if something is broken or if there are inconsistencies of any sort?

@Ben8t
Copy link
Member

Ben8t commented Nov 20, 2024

Very neat globally speaking 🎉
Few adjustements:

  • On Namespace page, when I'm on a specific namespace I can still filter by another namespace 🤔
    image

  • On flow page (overvie, execution, logs) the filter is on the namespace while it should be on flow_id (at least something tied to the flow). Removing the filter still keep the scope to the flow_id so it's ok; but changing to another namespace for example still give results -> should be tied to flow

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend Needs backend code changes enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants