Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): add missing filter tooltips #5942

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(ui): add missing filter tooltips #5942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ui/src/components/filter/KestraFilter.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@
</el-select>

<el-button-group class="d-inline-flex">
<el-button :icon="Magnify" @click="triggerSearch" />
<kicon :tooltip="$t('search')" placement="bottom">
<el-button :icon="Magnify" @click="triggerSearch" />
</kicon>
<Save :disabled="!current.length" :prefix :current />
<Refresh v-if="refresh.shown" @refresh="refresh.callback" />
<Settings v-if="settings.shown" :settings />
Expand Down Expand Up @@ -82,6 +84,7 @@
import Label from "./components/Label.vue";
import Save from "./components/Save.vue";
import Settings from "./components/Settings.vue";
import Kicon from "../Kicon.vue";

import Magnify from "vue-material-design-icons/Magnify.vue";

Expand Down
5 changes: 4 additions & 1 deletion ui/src/components/filter/components/Save.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
<el-button disabled :icon="Save" @click="toggle(true)" />
</el-tooltip>

<el-button v-else :icon="Save" @click="toggle(true)" />
<kicon v-else :tooltip="$t('filters.save.dialog.heading')" placement="bottom">
<el-button :icon="Save" @click="toggle(true)" />
</kicon>

<el-dialog
v-model="visible"
Expand Down Expand Up @@ -53,6 +55,7 @@
const {t} = useI18n({useScope: "global"});

import Label from "./Label.vue";
import Kicon from "../../Kicon.vue";

import Save from "vue-material-design-icons/ContentSaveOutline.vue";

Expand Down
6 changes: 5 additions & 1 deletion ui/src/components/filter/components/Settings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<template>
<el-dropdown trigger="click" placement="bottom-end">
<el-button :icon="TableCog" />
<kicon :tooltip="$t('settings.label')" placement="bottom">
<el-button :icon="TableCog" />
</kicon>

<template #dropdown>
<el-dropdown-menu class="py-2 settings-dropdown">
Expand All @@ -18,6 +20,8 @@
</template>

<script setup lang="ts">
import Kicon from "../../Kicon.vue";

import TableCog from "vue-material-design-icons/TableCog.vue";

import {useI18n} from "vue-i18n";
Expand Down
5 changes: 4 additions & 1 deletion ui/src/components/filter/components/history/History.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
placement="bottom-start"
@visible-change="loadAll"
>
<el-button :icon="History" class="rounded-0 rounded-start" />
<kicon :tooltip="$t('filters.recent.label')" placement="bottom">
<el-button :icon="History" class="rounded-0 rounded-start" />
</kicon>

<template #dropdown>
<el-dropdown-menu class="py-2 history-dropdown">
Expand Down Expand Up @@ -67,6 +69,7 @@
const {t} = useI18n({useScope: "global"});

import HistoryItem from "./HistoryItem.vue";
import Kicon from "../../../Kicon.vue";

import History from "vue-material-design-icons/History.vue";
import DeleteOutline from "vue-material-design-icons/DeleteOutline.vue";
Expand Down
Loading