Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: difference between verb remove and delete #74

Closed
SevenOutman opened this issue Mar 21, 2022 · 2 comments
Closed

Suggestion: difference between verb remove and delete #74

SevenOutman opened this issue Mar 21, 2022 · 2 comments

Comments

@SevenOutman
Copy link
Contributor

Hi Artem, thanks for this cheatsheet and the A/HC/LC pattern!

I still find it bit ambiguous for remove and delete when talking about relations instead of entities. I prefer remove being used on a relation, e.g. remove a member from a team. But the term delete still makes sense if explained as "erases the relation from the realms of existence.".

So I'd suggest explaining the difference between remove and delete by looking at their opposite actions - add and create. I find the key difference between add and create is that add needs a destination while create requires no destination. Readers can get confused when they find something can be either removed or deleted from somewhere, but they will then realize that it can only be added not created to somewhere.

Take the team member relation as an example, I can add a member to a team but cannot "create a member to a team", thus remove is used instead of delete.

@kettanaito
Copy link
Owner

Hey, @SevenOutman. Thank you for your kinds words!

I absolutely love your example and I think it should make it to the public guideline. The add/create analogy in comparison to remove/delete is fantastic. Please, would you be interested in opening a pull request with this suggestion?

@SevenOutman
Copy link
Contributor Author

Sure. So glad I can help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants