Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Own error type #42

Closed
leonjia0112 opened this issue Jan 16, 2019 · 6 comments
Closed

Own error type #42

leonjia0112 opened this issue Jan 16, 2019 · 6 comments
Assignees

Comments

@leonjia0112
Copy link
Contributor

Would it be better if there is an error type for our own crate that can map from other error? (e.g. Fromio::Errror, etc)

Because now the err handling type is a boxed string, which looks not professional. :)

@frozencemetery
Copy link
Contributor

(Per out-of-band conversation, this is a good idea.)

@lukehinds
Copy link
Member

Likely another one that can be closed (based on the merged PR above)

@frozencemetery
Copy link
Contributor

@mbestavros how close are you on this?

@mbestavros
Copy link
Contributor

I've got a basic custom error for crypto.rs working on my end. I'm currently hashing out the best way to wrap ErrorStack errors thrown by rust-openssl; once that's done, I'll integrate them into the existing bindings and push for review.

@mbestavros
Copy link
Contributor

@frozencemetery and @lukehinds: The above two PRs (#49 and #52) implement a custom error type for crypto.rs and adjust the return types of the functions introduced in #43, as specified. Unless we'd like to keep this issue open to encapsulate other potential custom errors elsewhere in the codebase, I think this is fair game to be resolved.

(Personally, I think it'd make more sense to open separate issues for other custom error types, should we want to pursue them.)

@frozencemetery
Copy link
Contributor

Agreed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants