We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In Cmake, FindBamTools.cmake:
find_library(BAMTOOLS_LIBRARY bamtools PATHS ${BAMTOOLS_ROOT}/lib PATH_SUFFIXES bamtools ../lib)
so finding BAMTOOLS fails no matter what env vars are set to.
bamtools 2.5.0 installs in library directory named lib64, not lib.
The text was updated successfully, but these errors were encountered:
Need a new pull request?
diff --git a/CMake/FindBamTools.cmake b/CMake/FindBamTools.cmake index 333ac17..aff5c47 100644 --- a/CMake/FindBamTools.cmake +++ b/CMake/FindBamTools.cmake @@ -9,7 +9,7 @@ # BAMTOOLS_FOUND - true if BAM has been found and can be used find_path(BAMTOOLS_INCLUDE_DIR api/BamReader.h PATHS ${BAMTOOLS_ROOT}/include PATH_SUFFIXES bamtools ../include ../include/bamtools) -find_library(BAMTOOLS_LIBRARY bamtools PATHS ${BAMTOOLS_ROOT}/lib PATH_SUFFIXES bamtools ../lib) +find_library(BAMTOOLS_LIBRARY bamtools PATHS ${BAMTOOLS_ROOT}/lib64 PATH_SUFFIXES bamtools ../lib) include(FindPackageHandleStandardArgs) FIND_PACKAGE_HANDLE_STANDARD_ARGS(BAMTOOLS
Sorry, something went wrong.
Hi @benjaminfang
Yes, please add to the existing PR and update. There are several things here to update, and I never had the bandwidth to do it properly.
I think the latest Docker image is here btw: https://hub.docker.com/u/pkharchenkolab
OK, done. please review.
No branches or pull requests
In Cmake, FindBamTools.cmake:
find_library(BAMTOOLS_LIBRARY bamtools PATHS ${BAMTOOLS_ROOT}/lib PATH_SUFFIXES bamtools ../lib)
so finding BAMTOOLS fails no matter what env vars are set to.
bamtools 2.5.0 installs in library directory named lib64, not lib.
The text was updated successfully, but these errors were encountered: