-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/330 private groups #753
base: master
Are you sure you want to change the base?
Conversation
When this is enabled, the website can be easily tested with multiple accounts
4507127
to
b931f77
Compare
b931f77
to
9740606
Compare
It lost the behaviour on a destruction. Refactored code to don't use destruction.
subfeatures: - Hide the user's name if needed - Show approve button on unapproved users for moderators
This reverts commit 9d26d2b.
1e6f738
to
8a33968
Compare
We could send emails to the user when they are approved or kicked out. |
} | ||
|
||
export async function down(knex: Knex): Promise<void> { | ||
// TODO: drop enum `group_roles` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop the enum on migrate:down, or else the second migrate:up will fail, because the enum already exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could use some help with this one 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried searching knex docs but didn't really find anything, worst case you can use .raw
with DROP TYPE group_roles
.
Closes #330