Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fuel serialization to be compatible with Android #765

Closed
yamilagammeri opened this issue Sep 4, 2020 · 1 comment · Fixed by #768
Closed

Update fuel serialization to be compatible with Android #765

yamilagammeri opened this issue Sep 4, 2020 · 1 comment · Fixed by #768

Comments

@yamilagammeri
Copy link

yamilagammeri commented Sep 4, 2020

Bug Report

Description

I attempted to upgrade the version of Serialization that Fuel uses as due to a package name change I was getting duplicated symbols. I've attached the build log with some errors caused by using the 1.0.0 serialization release.

It would be great if this package could be updated, thanks!

To Reproduce

Steps to reproduce the behavior:

  1. Go to build.gradle
  2. Scroll down to Dependencies
  3. Add this implementation "implementation "com.github.kittinunf.fuel:fuel-kotlinx-serialization:$fuel_version""
  4. Sync Gradle
// Test case or sample that shows broken behaviour and expected behaviour
https://jitpack.io/com/github/Bowel-Prep/fuel/master-1.16.0-ge9932e8-139/build.log 

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

N/A

Environment

Development Machine

Complete the following information if applicable

  • OS: Windows 10
  • IDE: Android Studio
  • Fuel version: 2.2.3
  • Kotlin version: 1.4.0

Smartphone or Emulator

Complete the following information if applicable

  • Device: Pixel3A
  • OS: Android 11.0

Additional context

Add any other context about the problem here.

> Task :fuel-kotlinx-serialization:compileKotlin FAILED
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (11, 30): Using 'ImplicitReflectionSerializer' is an error. This annotation is obsolete and deprecated for removal
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (20, 18): Using 'Json(SubtypeToDetectStable): Json' is an error. Deprecated in the favour of Json {} builder function during serialization 1.0 API stabilization.
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (20, 23): Using 'JsonConfiguration' is an error. This class is deprecated for removal during serialization 1.0 API stabilization.
For configuring Json instances, the corresponding builder function can be used instead, e.g. instead of'Json(JsonConfiguration.Stable.copy(isLenient = true))' 'Json { isLenient = true }' should be used.
Instead of storing JsonConfiguration instances of the code, Json instances can be used directly:'Json(MyJsonConfiguration.copy(prettyPrint = true))' can be replaced with 'Json(from = MyApplicationJson) { prettyPrint = true }'
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (24, 2): Using 'ImplicitReflectionSerializer' is an error. This annotation is obsolete and deprecated for removal
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (26, 18): Using 'Json(SubtypeToDetectStable): Json' is an error. Deprecated in the favour of Json {} builder function during serialization 1.0 API stabilization.
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (26, 23): Using 'JsonConfiguration' is an error. This class is deprecated for removal during serialization 1.0 API stabilization.
For configuring Json instances, the corresponding builder function can be used instead, e.g. instead of'Json(JsonConfiguration.Stable.copy(isLenient = true))' 'Json { isLenient = true }' should be used.
Instead of storing JsonConfiguration instances of the code, Json instances can be used directly:'Json(MyJsonConfiguration.copy(prettyPrint = true))' can be replaced with 'Json(from = MyApplicationJson) { prettyPrint = true }'
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (28, 29): This declaration is experimental and its usage must be marked with '@kotlinx.serialization.InternalSerializationApi' or '@OptIn(kotlinx.serialization.InternalSerializationApi::class)'
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (33, 18): Using 'Json(SubtypeToDetectStable): Json' is an error. Deprecated in the favour of Json {} builder function during serialization 1.0 API stabilization.
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (33, 23): Using 'JsonConfiguration' is an error. This class is deprecated for removal during serialization 1.0 API stabilization.
For configuring Json instances, the corresponding builder function can be used instead, e.g. instead of'Json(JsonConfiguration.Stable.copy(isLenient = true))' 'Json { isLenient = true }' should be used.
Instead of storing JsonConfiguration instances of the code, Json instances can be used directly:'Json(MyJsonConfiguration.copy(prettyPrint = true))' can be replaced with 'Json(from = MyApplicationJson) { prettyPrint = true }'
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (36, 2): Using 'ImplicitReflectionSerializer' is an error. This annotation is obsolete and deprecated for removal
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (39, 18): Using 'Json(SubtypeToDetectStable): Json' is an error. Deprecated in the favour of Json {} builder function during serialization 1.0 API stabilization.
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (39, 23): Using 'JsonConfiguration' is an error. This class is deprecated for removal during serialization 1.0 API stabilization.
For configuring Json instances, the corresponding builder function can be used instead, e.g. instead of'Json(JsonConfiguration.Stable.copy(isLenient = true))' 'Json { isLenient = true }' should be used.
Instead of storing JsonConfiguration instances of the code, Json instances can be used directly:'Json(MyJsonConfiguration.copy(prettyPrint = true))' can be replaced with 'Json(from = MyApplicationJson) { prettyPrint = true }'
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (40, 43): This declaration is experimental and its usage must be marked with '@kotlinx.serialization.InternalSerializationApi' or '@OptIn(kotlinx.serialization.InternalSerializationApi::class)'
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (44, 18): Using 'Json(SubtypeToDetectStable): Json' is an error. Deprecated in the favour of Json {} builder function during serialization 1.0 API stabilization.
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (44, 23): Using 'JsonConfiguration' is an error. This class is deprecated for removal during serialization 1.0 API stabilization.
For configuring Json instances, the corresponding builder function can be used instead, e.g. instead of'Json(JsonConfiguration.Stable.copy(isLenient = true))' 'Json { isLenient = true }' should be used.
Instead of storing JsonConfiguration instances of the code, Json instances can be used directly:'Json(MyJsonConfiguration.copy(prettyPrint = true))' can be replaced with 'Json(from = MyApplicationJson) { prettyPrint = true }'
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (47, 2): Using 'ImplicitReflectionSerializer' is an error. This annotation is obsolete and deprecated for removal
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (49, 18): Using 'Json(SubtypeToDetectStable): Json' is an error. Deprecated in the favour of Json {} builder function during serialization 1.0 API stabilization.
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (49, 23): Using 'JsonConfiguration' is an error. This class is deprecated for removal during serialization 1.0 API stabilization.
For configuring Json instances, the corresponding builder function can be used instead, e.g. instead of'Json(JsonConfiguration.Stable.copy(isLenient = true))' 'Json { isLenient = true }' should be used.
Instead of storing JsonConfiguration instances of the code, Json instances can be used directly:'Json(MyJsonConfiguration.copy(prettyPrint = true))' can be replaced with 'Json(from = MyApplicationJson) { prettyPrint = true }'
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (50, 29): This declaration is experimental and its usage must be marked with '@kotlinx.serialization.InternalSerializationApi' or '@OptIn(kotlinx.serialization.InternalSerializationApi::class)'
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (54, 18): Using 'Json(SubtypeToDetectStable): Json' is an error. Deprecated in the favour of Json {} builder function during serialization 1.0 API stabilization.
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (54, 23): Using 'JsonConfiguration' is an error. This class is deprecated for removal during serialization 1.0 API stabilization.
For configuring Json instances, the corresponding builder function can be used instead, e.g. instead of'Json(JsonConfiguration.Stable.copy(isLenient = true))' 'Json { isLenient = true }' should be used.
Instead of storing JsonConfiguration instances of the code, Json instances can be used directly:'Json(MyJsonConfiguration.copy(prettyPrint = true))' can be replaced with 'Json(from = MyApplicationJson) { prettyPrint = true }'
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (56, 58): Unresolved reference: parse
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (67, 2): Using 'ImplicitReflectionSerializer' is an error. This annotation is obsolete and deprecated for removal
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (69, 18): Using 'Json(SubtypeToDetectStable): Json' is an error. Deprecated in the favour of Json {} builder function during serialization 1.0 API stabilization.
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (69, 23): Using 'JsonConfiguration' is an error. This class is deprecated for removal during serialization 1.0 API stabilization.
For configuring Json instances, the corresponding builder function can be used instead, e.g. instead of'Json(JsonConfiguration.Stable.copy(isLenient = true))' 'Json { isLenient = true }' should be used.
Instead of storing JsonConfiguration instances of the code, Json instances can be used directly:'Json(MyJsonConfiguration.copy(prettyPrint = true))' can be replaced with 'Json(from = MyApplicationJson) { prettyPrint = true }'
e: /home/jitpack/build/fuel-kotlinx-serialization/src/main/kotlin/com/github/kittinunf/fuel/serialization/FuelSerialization.kt: (70, 36): This declaration is experimental and its usage must be marked with '@kotlinx.serialization.InternalSerializationApi' or '@OptIn(kotlinx.serialization.InternalSerializationApi::class)'
@kittinunf
Copy link
Owner

kittinunf commented Sep 9, 2020

Yes, we're working on it on #766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants