Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Takes ToolchainCL definition outside the main #478

Merged
merged 1 commit into from
May 5, 2020
Merged

Takes ToolchainCL definition outside the main #478

merged 1 commit into from
May 5, 2020

Conversation

AndreMiras
Copy link
Member

I can't justify why it would need to be inside the main.
Let's take it out and see what breaks ;)

@AndreMiras
Takes ToolchainCL definition outside the main
30cca1e 
I can't justify why it would need to be inside the main.
Let's take it out and see what breaks ;)
@AndreMiras
Copy link
Member Author

The diff is pretty unreadable. Basically I've simply removed the ToolchainCL class definition outside the main() and un-indented it. Now only the initialisation is within the main()

@AndreMiras
Copy link
Member Author

Build is green, merging 🚀

@AndreMiras AndreMiras merged commit 3974a1e into kivy:master May 5, 2020
@AndreMiras AndreMiras deleted the feature/top_level_toolchaincl branch May 5, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AndreMiras