Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin flask version and dependencies #510

Merged
merged 2 commits into from
May 29, 2020
Merged

Pin flask version and dependencies #510

merged 2 commits into from
May 29, 2020

Conversation

Zen-CODE
Copy link
Member

No description provided.

AndreMiras
AndreMiras reviewed May 28, 2020
View reviewed changes
kivy_ios/recipes/itsdangerous/__init__.py Outdated
@@ -14,11 +14,10 @@ def install(self):
build_dir = self.get_build_dir(arch.arch)
hostpython = sh.Command(self.ctx.hostpython)
build_env = arch.get_env()
dest_dir = join(self.ctx.dist_dir, "root", "python")
dest_dir = join(self.ctx.dist_dir, "root", "python3")
build_env['PYTHONPATH'] = join(dest_dir, 'lib', 'python3.8', 'site-packages')
cmd = sh.Command("sed")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish the linter could post that comment on the exact line for us

kivy_ios/recipes/itsdangerous/__init__.py:19:9: F841 local variable 'cmd' is assigned to but never used

Copy link
Member Author

@Zen-CODE Zen-CODE May 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice. But, I should just rum the pep8 checker locally I suppose... Not in that habit on this repo yet. Should add it as a hook...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also often don't run it locally because we think changes are trivial, but it's easy to forget something or make typos. That's why we have CI to gently remind us :D

@Zen-CODE
Copy link
Member Author

For reference, as a command run now.

(venv) richard@Richards-MBP temp % pip install flask
Collecting flask
  Downloading Flask-1.1.2-py2.py3-none-any.whl (94 kB)
     |████████████████████████████████| 94 kB 2.8 MB/s 
Collecting Jinja2>=2.10.1
  Using cached Jinja2-2.11.2-py2.py3-none-any.whl (125 kB)
Collecting click>=5.1
  Using cached click-7.1.2-py2.py3-none-any.whl (82 kB)
Collecting Werkzeug>=0.15
  Downloading Werkzeug-1.0.1-py2.py3-none-any.whl (298 kB)
     |████████████████████████████████| 298 kB 4.5 MB/s 
Collecting itsdangerous>=0.24
  Using cached itsdangerous-1.1.0-py2.py3-none-any.whl (16 kB)
Collecting MarkupSafe>=0.23
  Using cached MarkupSafe-1.1.1-cp37-cp37m-macosx_10_6_intel.whl (18 kB)
Installing collected packages: MarkupSafe, Jinja2, click, Werkzeug, itsdangerous, flask
Successfully installed Jinja2-2.11.2 MarkupSafe-1.1.1 Werkzeug-1.0.1 click-7.1.2 flask-1.1.2 itsdangerous-1.1.0

AndreMiras
AndreMiras approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks!

@AndreMiras
Copy link
Member

Maybe splitting up the PR we have more chance of seeing the CI passing for some of them

@Zen-CODE Zen-CODE merged commit 9dc7e41 into master May 29, 2020
@Zen-CODE Zen-CODE deleted the flask/pin branch May 29, 2020 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zen-CODE @AndreMiras