Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded site-packages Python version references #512

Closed
AndreMiras opened this issue Jun 1, 2020 · 4 comments
Closed

Hardcoded site-packages Python version references #512

AndreMiras opened this issue Jun 1, 2020 · 4 comments
Milestone

Comments

@AndreMiras
Copy link
Member

Versions

  • Python : N/A
  • MacOS version : N/A
  • XCode Version : N/A
  • Cython version : N/A

Describe the bug
Recipes often have hardcoded references to Python versions, for instance:

This is a problem because some recipes may then not work with Python 3.7 or 3.8 while it should work with both.

To Reproduce

grep -r 'python3.[78]' kivy_ios/recipes/

Expected behavior
Instead we would like these to dynamically use the target Python version.

@Zen-CODE
Copy link
Member

@AndreMiras Do you have a suggested approach to solving this? Perhaps a first step would be to import a version number as a constant from a central py file? Seems cleaner than an env variable....

@AndreMiras
Copy link
Member Author

I imagine it could be retrieved dynamically from the compiled host python version.
So we could have maybe an helper function that would return that path dynamically and use it in all the places. I think that could be a good start.
Also I'm suspecting setting the PYTHONPATH may not actually be needed for most of the recipes, this should be fairly easy to find out.

@misl6 misl6 added this to the 1.3.0 milestone Mar 27, 2021
@misl6
Copy link
Member

misl6 commented Mar 27, 2021

PR #601 inadvertently fixes this issue.

Keeping it open until We merge it.

@AndreMiras
Copy link
Member Author

Merged, thanks for the heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants