-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Update openssl and ffmpeg version to fix build issues #562
Conversation
I can confirm this works and builds successfully with Mac Catalina + XCode 11.2.1.
|
Trying to run the app, it generates the following error.
|
Version n3.4.8 - ERROR: openssl not found
|
@Zen-CODE sorry I never mentioned this - when I was fighting with Xcode 12, and I went back to Xcode 11 to get things working, I had to add "libiconv.tbd" (or something like that) to the list of "Frameworks" in the Xcode project - I did it in the GUI but I assume some automagic fix could be made in the Xcode project file? EDIT: FWIW it works in the simulator, but I didn't have the opportunity to test on real device yet (or rather it crashes but I don't have logs so I don't know why). |
@Zen-CODE I have an upcoming PR to get this one working on Xcode 12.2 + a demo app, meanwhile can you please upgrade also |
You don't want to do that as part of this PR? Is there a reason for that? |
For the The fixes that I made on the other upcoming PR are quite unrelated but at the same time also fixes an issue that was triggered while testing this PR, so I prefer to hold it separate for future maintenance. |
Sure, makes sense. I'll prep and test that shortly... |
@misl6 Merged those changes so you are unblocked asap. Let's hope it works 👍 |
With all the recent changes + #571 you should be able to run on both Simulator and real device a videoplayer demo app that uses Just for reference, I created a simple demo app for demonstrating / testing it. I'm able to run it on Simulator + a real device with the latest iOS version. |
It still gives an "OpenSSL not found" when building with the existing ffmpeg (Testing on XCode 12.1 first). Please could you change the version in the ffmpeg recipe to "n4.3.1" to fix that in this PR? |
Thanks for creating an app to test with, but I can't get it running for love or money. It builds, but gives me the attached permissions error when I try to run. Lots of googling + experiment get me nowhere...Building touchtracer works fine though, and it does build so it's still an improvement as the older ffmpeg does not! And I can't see that these changes would cause this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm it fixes the build issues Xcode 11.2.1/Catalina
This updates the openssl and ffmpeg recipes, mainly the fix the outdated entry point used by the current ffmpeg recipe.
Relates to this PR: #552
Informed by this patch: https://www.github.com/kivy/python-for-android/tree/develop/pythonforandroid%2Frecipes%2Fffmpeg%2Fpatches%2Fconfigure.patch