Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Date meta ZIM (invalid) produces non-ISO dc:created/update in OPDS #902

Open
rgaudin opened this issue Feb 23, 2023 · 1 comment
Labels
Milestone

Comments

@rgaudin
Copy link
Member

rgaudin commented Feb 23, 2023

When a book doesn't specify a Date metadata (neither in-ZIM or in the library.xml), the returned OPDS entry includes invalid values for updated and dc:issued.

Given the spec mandates the Date metadata, we should not care much about how to handle it. We've also discussed in other tickets whether to support invalid ZIM at all.

curl 'https://library.kiwix.org/catalog/v2/entry/43b94328-4e20-9ccd-1e07-8d8fa551bfaf'

<?xml version="1.0" encoding="UTF-8"?>
  <entry>
    <id>urn:uuid:43b94328-4e20-9ccd-1e07-8d8fa551bfaf</id>
    <title>Le Dojo de Plume</title>
    <updated>T00:00:00Z</updated>
    <summary>Tu trouveras dans le Dojo de nombreuses activités amusantes pour progresser en français.</summary>
    <language>fra</language>
    <name>plume-app.co_fr_all</name>
    <flavour></flavour>
    <category></category>
    <tags>_ftindex:no;_pictures:yes;_videos:yes;_details:yes</tags>
    <articleCount>191</articleCount>
    <mediaCount>122</mediaCount>
    <link rel="http://opds-spec.org/image/thumbnail"
          href="/catalog/v2/illustration/43b94328-4e20-9ccd-1e07-8d8fa551bfaf/?size=48"
          type="image/png;width=48;height=48;scale=1"/>
    <link type="text/html" href="/content/plume-app.co_fr_all_2021-12" />
    <author>
      <name>Plume</name>
    </author>
    <publisher>
      <name>Kiwix</name>
    </publisher>
    <dc:issued>T00:00:00Z</dc:issued>
    <link rel="http://opds-spec.org/acquisition/open-access" type="application/x-zim" href="https://download.kiwix.org/zim/other/plume-app.co_fr_all_2021-12.zim.meta4" length="7667712" />
  </entry>

Opening this for history's sake but also recreating the ZIM and openzim/python-scraperlib#95.

Incidentally it only concerns a single ZIM 🤷‍♂️

@kelson42 kelson42 added this to the 12.1.0 milestone Feb 23, 2023
@kelson42
Copy link
Collaborator

See openzim/overview#9 (comment)

@kelson42 kelson42 modified the milestones: 12.1.0, 12.2.0 Jun 2, 2023
@kelson42 kelson42 modified the milestones: 13.0.0, 13.1.0 Jul 26, 2023
@kelson42 kelson42 modified the milestones: 13.2.0, 13.3.0 Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants