Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a command to check whether it's logged in or not #200

Closed
kmyk opened this issue Dec 3, 2018 · 2 comments · Fixed by #288
Closed

add a command to check whether it's logged in or not #200

kmyk opened this issue Dec 3, 2018 · 2 comments · Fixed by #288
Assignees

Comments

@kmyk
Copy link
Member

kmyk commented Dec 3, 2018

No description provided.

@kmyk kmyk added the feature label Jan 26, 2019
@kmyk
Copy link
Member Author

kmyk commented Jan 29, 2019

#276 の方針的にもほしい やります

@kmyk kmyk self-assigned this Jan 29, 2019
@kmyk
Copy link
Member Author

kmyk commented Jan 29, 2019

subcommand をどう生やすかはUIの設計問題になる。選択肢は以下の3つ

  1. oj check-logged-in TARGET
  2. oj login --check TARGET
  3. (古いものを oj login --password TARGET に移した上で) oj login TARGET

(1.) をするなら (2.) の方がよさそう。(2.) の --check はつまり --dry-run option なので自然なoptionであるため。機能が本質的に違うのなら新しいコマンドを生やすべきだが、そうでなく、新しいコマンドが増えると管理側も使う側も混乱するだけ。

(2.) と (3.) の比較は迷うが、迷うなら互換性を気にして (2.) がよさそう。(3.) は「より安全な」方法でのloginへ強く誘導する点で強いが、直感的な動作かと言うとそうでもなく、一長一短であるため。ただし oj login TARGET の実行時に cookie.jar を直接編集する選択肢の存在を伝えるようにはすべき。

kmyk added a commit that referenced this issue Feb 1, 2019
kmyk added a commit that referenced this issue Feb 1, 2019
kmyk added a commit that referenced this issue Feb 2, 2019
kmyk added a commit that referenced this issue Feb 2, 2019
fukatani added a commit that referenced this issue Feb 3, 2019
#200 add --check option to login command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant