feature: select submit language by name #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
あまり関係ありませんが、自作の開発環境と連携させていただいております。便利に使わせてもらってます。 |
kmyk
added a commit
that referenced
this pull request
Jul 29, 2018
|
ありがとうございます。あった方がよいと気付いてはいたがずっと放置されてた機能なのですごく助かります。 |
|
PyPIの方に反映させておきました。 |
|
素早い対応ありがとうございます！ |
kmyk
added a commit
that referenced
this pull request
Jul 30, 2018
kmyk
added a commit
that referenced
this pull request
Jul 30, 2018
|
修正のために足したつもりのcommitが反映されてなかったのと、その修正自体にも不備がありました。こんどこそちゃんと修正したので更新してください。 |
|
あーいえいえ、私のミスです。 IDを返すつもりが、言語名を返してましたね。凡ミス。 早速の反映反映ありがとうございます。 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
submit時、IDの代わりに文字列で入力したいです(毎回テーブル調べるのが面倒なため)
入力例
正常時
Rust (1.15.1)を選択したものとして、処理を続行します。
異常時１
Python2 (2.7.6)かPython3 (3.4.3)か絞れないので、どっちか選んでねとメッセージ出して処理をストップします。
異常時2
そんなものはないぞ、ということで従来通りのエラーメッセージを出します。
どうでしょうか？