#318 #317 add features to list contests and problems of AtCoder #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fukatani
reviewed
Feb 19, 2019
| @@ -98,12 +100,154 @@ def _report_messages(cls, msgs: List[str], unexpected: bool = False) -> bool: | |||
| log.failure('unexpected messages found') | |||
| return bool(msgs) | |||
|
|
|||
| def iterate_contests(self, lang: str = 'ja', session: Optional[requests.Session] = None) -> Generator['AtCoderContest', None, None]: | |||
| assert lang in ('ja', 'en') # NOTE: "lang=ja" is required to see some Japanese-local contests. However you can use "lang=en" to see the English names of contests. | |||
There was a problem hiding this comment.
このNOTEは関数全体の注釈のような気もしていて関数のdocにしたほうがいいかもと思いましたが、どうでしょう？
pydocにすると、autogenされたrstファイルに説明ものるようになるんでしたっけ。
There was a problem hiding this comment.
この指摘はまったく正しいのですが、後のコミットで docstring 化してるので見過してください
最終的には https://online-judge-tools.readthedocs.io/en/develop/onlinejudge.service.atcoder.html#onlinejudge.service.atcoder.AtCoderService.iterate_contests という形で document に乗ります
|
これも Toph とは衝突しないのでよさそうなら merge してください |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
コンテストの列挙と問題の列挙ができるようにします