Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#437: fix a bug around --ignore-backup of test subcommand #441

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

kmyk
Copy link
Member

@kmyk kmyk commented Jun 11, 2019

close #437

https://github.com/kmyk/online-judge-tools/blob/49b2af11f6c4120dc79b7281e1837d82b9883296/onlinejudge/_implementation/format_utils.py#L78-L80

この path.stem が原因でした。これだと /path/to/sample.in のようなものに対し sample が返ってきてしまうので間違いで、 path.name が正解です。

テストも足しました。

@kmyk kmyk requested a review from fukatani June 11, 2019 16:46
Copy link
Contributor

@fukatani fukatani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fukatani
Copy link
Contributor

テストをrerunさせました。パスすればOKです。

@fukatani fukatani merged commit 85ebf14 into master Jun 12, 2019
@fukatani fukatani deleted the issue/437 branch June 12, 2019 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: --ignore-backup dosn't work
2 participants