Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NONE: fix a bug of AtCoderSubmission() for submissions whose status is CE #449

Merged
merged 2 commits into from
Jun 16, 2019

Conversation

kmyk
Copy link
Member

@kmyk kmyk commented Jun 15, 2019

CE なケースに対する提出の詳細を取得しようとすると落ちます。修正してテストも追加します。

@kmyk kmyk requested a review from fukatani June 15, 2019 02:07
@kmyk
Copy link
Member Author

kmyk commented Jun 15, 2019

CI は POJ 関係なく落ちてたぽい。直します

@kmyk kmyk assigned kmyk and unassigned fukatani Jun 15, 2019
Copy link
Contributor

@fukatani fukatani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fukatani
Copy link
Contributor

あ、テスト落ちてますね。
通ったらもう一度見ます。

@kmyk kmyk assigned fukatani and unassigned kmyk Jun 16, 2019
@kmyk
Copy link
Member Author

kmyk commented Jun 16, 2019

テスト再々実行したら通りました。再実行ボタンを押し忘れてただけだったようです。
このままマージします。

@kmyk kmyk merged commit 3a1a973 into master Jun 16, 2019
@kmyk kmyk deleted the fix/compile-error branch June 16, 2019 10:41
fukatani added a commit to fukatani/online-judge-tools that referenced this pull request Jul 8, 2019
fukatani added a commit to fukatani/online-judge-tools that referenced this pull request Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants