Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#514: fix a problem of WebDriver on Windows #517

Merged
merged 1 commit into from
Sep 13, 2019
Merged

#514: fix a problem of WebDriver on Windows #517

merged 1 commit into from
Sep 13, 2019

Conversation

kmyk
Copy link
Member

@kmyk kmyk commented Sep 13, 2019

close #514
もともと例外を catch することでウィンドウが閉じられたことを確認していましたが、 Windows 環境下では飛ぶ例外の種類が異なるようです。最も広く受けられる例外クラスを指定すれば解決するので、そのようにします。

@kmyk kmyk requested a review from fukatani September 13, 2019 14:28
Copy link
Contributor

@fukatani fukatani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fukatani fukatani merged commit 6bd6d71 into master Sep 13, 2019
@fukatani fukatani deleted the issue/514 branch September 13, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

login: fails on Windows + WebDriver
2 participants