Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[breaking consistency] Unsupport --overwrite option and abort download if file already exists. #575

Merged
merged 4 commits into from
Oct 31, 2019
Merged

[breaking consistency] Unsupport --overwrite option and abort download if file already exists. #575

merged 4 commits into from
Oct 31, 2019

Conversation

fukatani
Copy link
Contributor

@fukatani fukatani commented Oct 25, 2019 •
edited
Loading

  • remove --overwrite option
  • abort download if file already exists.
  • raise InvalidURL if contest is not supported. (Sorry, this feature can be split to other PR)

@fukatani fukatani added this to the v8.0.0 milestone Oct 25, 2019
@fukatani fukatani changed the title [WIP] [breaking consistency] Unsupport --overwrite option and abort download if file already exists. [breaking consistency] Unsupport --overwrite option and abort download if file already exists. Oct 25, 2019
@kmyk
Copy link
Member

kmyk commented Oct 31, 2019

すでに --overwrite が存在していた事実を知らなくてびっくりしています (blame したら initial commit で自分で作っていたらしい)

kmyk
kmyk approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@kmyk kmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmyk
Copy link
Member

kmyk commented Oct 31, 2019

Although this breaks the compatibility of the command line interface, I think the effect is enough small.

@kmyk kmyk merged commit 670bbed into online-judge-tools:master Oct 31, 2019
@kmyk kmyk mentioned this pull request Oct 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmyk kmyk kmyk approved these changes

Assignees

@kmyk kmyk

Labels
None yet
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fukatani @kmyk