Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw exceptions if the titles of sample cases are abnormal #620

Merged
merged 1 commit into from
Nov 23, 2019

Conversation

kmyk
Copy link
Member

@kmyk kmyk commented Nov 21, 2019

fix #615

サンプルの解析の際に <h3>Sample Input 2</h3> みたいなところを見て警告を出しているのですが、これを警告でなくエラーにします。

#615 の例を完全に解析しきるのは無理 (できたとしても HTML parser の実装に強く依存してしまうのでどうせすぐ壊れる) ですので、これは諦めます。しかし、まずいのはエラーにならず正常終了してしまうことなので、このプルリクによって #615 が解決されます。

Copy link
Contributor

@fukatani fukatani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです。
travisでテストが終わってるのに、github上ではテスト中のように見えてよくわからないのでRestartしてみました。

@fukatani fukatani merged commit 7f5ffd1 into master Nov 23, 2019
@fukatani fukatani deleted the fix/615 branch November 23, 2019 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

download: add workaround for broken markup of AtCoder s8pc_4_d
2 participants