provide functions about sessions as a library #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PRありがとうございます！ |
|
使っているのは |
fukatani
reviewed
Dec 17, 2019
| @@ -353,6 +353,10 @@ def get_service(self) -> AtCoderService: | |||
| return AtCoderService() | |||
|
|
|||
| def list_problem_data(self, *, session: Optional[requests.Session] = None) -> List['AtCoderProblemData']: | |||
| """ | |||
| :raises Exception: if logging in is required to see the tasks page | |||
There was a problem hiding this comment.
Suggested change
| :raises Exception: if logging in is required to see the tasks page | |
| :raises NotLoggedInError: if logging in is required to see the tasks page |
There was a problem hiding this comment.
NotLoggedInError は飛ばなくて HTTPError みたいなやつになるはず (未確認) です。なのでたぶん Exception で正しい
|
@fukatani 確認ですが、 |
|
おっと、見逃してました。 ただ、ojで公開しないのは仕方がない感じはします。 |
|
(merge後で恐縮ですが、)私もfukunatiさんと同じ3つを使ってました 3つめはget_default_sessionに置き換えれば問題なさそうなので、問題ありません ありがとうございます！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#480 (comment)
onlinejudge._implementation.utilsのなかからいくつかonlinejudge.utilsに移したget_default_sessionwith_cookiejardefault_cookie_pathなども移した (with_cookiejarした結果から取れちゃうし、いっしょにあると便利だろうので)onlinejudge.sessionという手もあるが細かく切るよりひとつにまとめた方がなんとなく楽かな、ぐらいの気持ちです。より良いのが思い付いたら提案してください@yosupo06 これはあなたの目的のためによさそうですか？ ところで atcoder-tools 並に高機能でかつ AtCoder 以外にも対応してるラッパーはほしいので、期待しています