Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service: codeforces] ignore NavigableString from tag.children while … #728

Merged
merged 1 commit into from
Apr 18, 2020
Merged

Conversation

njkevlani
Copy link
Contributor

…downloading sample cases

Before this commit, downloading sample cases from codeforces was failing, probably
due to some format changes on codeforces website.

Following test cases were failing before this commit

FAILED tests/command_download_codeforces.py::DownloadCodeforcesTest::test_call_download_codeforces_contest_1080_a - subprocess.CalledProcessError: Command '['/home/nilesh/.python/py3/bin/...
FAILED tests/command_download_codeforces.py::DownloadCodeforcesTest::test_call_download_codeforces_contest_538_h - subprocess.CalledProcessError: Command '['/home/nilesh/.python/py3/bin/p...
FAILED tests/command_download_codeforces.py::DownloadCodeforcesTest::test_call_download_codeforces_gym_101020_a - subprocess.CalledProcessError: Command '['/home/nilesh/.python/py3/bin/py...
FAILED tests/command_download_codeforces.py::DownloadCodeforcesTest::test_call_download_codeforces_problemset_700_b - subprocess.CalledProcessError: Command '['/home/nilesh/.python/py3/bi...

Rest of the tests are as they were before.

…downloading sample cases

Before this commit, downloading sample cases from codeforces was failing, probably
due to some format changes on codeforces website.

Following test cases were failing before this commit
```
FAILED tests/command_download_codeforces.py::DownloadCodeforcesTest::test_call_download_codeforces_contest_1080_a - subprocess.CalledProcessError: Command '['/home/nilesh/.python/py3/bin/...
FAILED tests/command_download_codeforces.py::DownloadCodeforcesTest::test_call_download_codeforces_contest_538_h - subprocess.CalledProcessError: Command '['/home/nilesh/.python/py3/bin/p...
FAILED tests/command_download_codeforces.py::DownloadCodeforcesTest::test_call_download_codeforces_gym_101020_a - subprocess.CalledProcessError: Command '['/home/nilesh/.python/py3/bin/py...
FAILED tests/command_download_codeforces.py::DownloadCodeforcesTest::test_call_download_codeforces_problemset_700_b - subprocess.CalledProcessError: Command '['/home/nilesh/.python/py3/bi...
```

Rest of the tests are as they were before.
Copy link
Member

@kmyk kmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmyk kmyk merged commit 7718ad1 into online-judge-tools:master Apr 18, 2020
@kmyk
Copy link
Member

kmyk commented Apr 18, 2020

Thank you for pull requesting! We'll update the version of online-judge-tools soon.

@kmyk kmyk mentioned this pull request Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants