Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(source): Update to Knative eventing 0.13.0 #705

Merged
merged 15 commits into from
Mar 6, 2020
Merged

refactor(source): Update to Knative eventing 0.13.0 #705

merged 15 commits into from
Mar 6, 2020

Conversation

rhuss
Copy link
Contributor

@rhuss rhuss commented Mar 6, 2020 •
edited
Loading

  • Moved to "sources.knative.dev" API group
  • Replaced CronJobSource with PingSource (and removed unsupported options
    for service account, requests limits)
  • Move to versions:
    • SinkBinding v1alpha2
    • PingSource v1alpha2
    • ApiServerSource v1alpha1

rhuss added 8 commits March 5, 2020 12:27
@rhuss
chore(e2e): Optimized tests
6838709 
Smoke Tests now run before the E2E tests, but in the same cluster
@rhuss
chore: Removed unneeded test
ce1933b
@rhuss
fix
091e0b0
@rhuss
fix
93a86b6
@rhuss
fix
098953c
@rhuss
fix
d1a1d36
@rhuss
chore: Update to serving & eventing v0.13.0
f3fa722
@rhuss
refactor(source): Update to Knative eventing 0.13.0
7c1e05c 
* Moved to "sources.knative.dev" API group
* Replaced CronJobSource with PingSource (and removed unsupported options for service account, requests limits)
* Move to versions:
  - SinkBinding v1alpha2
  - PingSource v1alpha2
  - ApiServerSource v1alpha1
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 6, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 6, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2020
@rhuss rhuss mentioned this pull request Mar 6, 2020
Merged
@rhuss rhuss mentioned this pull request Mar 6, 2020
Closed
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/source/ping/create.go Do not exist 88.9%
pkg/kn/commands/source/ping/delete.go Do not exist 85.7%
pkg/kn/commands/source/ping/describe.go Do not exist 83.7%
pkg/kn/commands/source/ping/flags.go Do not exist 56.2%
pkg/kn/commands/source/ping/list.go Do not exist 78.3%
pkg/kn/commands/source/ping/ping.go Do not exist 59.1%
pkg/kn/commands/source/ping/update.go Do not exist 75.0%
pkg/sources/v1alpha1/apiserver_client.go Do not exist 93.2%
pkg/sources/v1alpha1/apiserver_client_mock.go Do not exist 77.3%
pkg/sources/v1alpha2/binding_client.go Do not exist 85.9%
pkg/sources/v1alpha2/binding_client_mock.go Do not exist 90.9%
pkg/sources/v1alpha2/client.go Do not exist 100.0%
pkg/sources/v1alpha2/ping_client.go Do not exist 91.7%
pkg/sources/v1alpha2/ping_client_mock.go Do not exist 77.3%

@dsimansk
Copy link
Contributor

dsimansk commented Mar 6, 2020

@maximilien I've gone through the PR (with focus on ping) and it seems all right. Feel free to call lgtm once you're on it.

@rhuss rhuss mentioned this pull request Mar 6, 2020
Merged
maximilien
maximilien reviewed Mar 6, 2020
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK let's get this in

/lgtm

docs/cmd/kn_source_ping_create.md
### Examples

```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove new line

docs/cmd/kn_source_ping_update.md
### Examples

```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2020
@knative-prow-robot knative-prow-robot merged commit 46d5e60 into knative:master Mar 6, 2020
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@k4leung4 @knative-prow-robot
Add CI support for istio version and istio mesh (knative#705)
bf22e8a 
Run additional configuration for istio/mesh combination.

1.0.7 mesh
1.0.7 nomesh
1.1.2 mesh
1.1.2 nomesh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilien maximilien maximilien left review comments

@cppforlife cppforlife Awaiting requested review from cppforlife

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees

@maximilien maximilien

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rhuss @knative-prow-robot @knative-metrics-robot @dsimansk @maximilien @googlebot