Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support plural resource nouns #812

Closed
mattmoor opened this issue Apr 18, 2020 · 7 comments
Closed

Support plural resource nouns #812

mattmoor opened this issue Apr 18, 2020 · 7 comments
Assignees
Labels
kind/feature New feature or request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@mattmoor
Copy link
Member

Feature request

In kubectl and tkn I can use either the singular or plural for resource names, but with kn I get an error when using the plural:

kn services list
Error: unknown command 'services'
Run 'kn --help' for usage.

IMO services should simply alias service.

@mattmoor mattmoor added the kind/feature New feature or request label Apr 18, 2020
@rhuss
Copy link
Contributor

rhuss commented Apr 20, 2020

+1 especially for commands that operate on multiple resource instances (but I wouldn't also mind so support both variants unconditionally eg. also kn services create)

@rhuss rhuss self-assigned this Apr 20, 2020
@navidshaikh
Copy link
Collaborator

should we also consider bringing other aliases with this?

for example

  • svc for services
  • rev for revisions
    etc

@duglin
Copy link
Contributor

duglin commented Apr 20, 2020

svc might be too easily confused with k8s svc

@rhuss
Copy link
Contributor

rhuss commented Apr 20, 2020

svc might be too easily confused with k8s svc

don't think this is a strong argument as the same applies for 'service' itself, too. (i.e. that it can be confused with a k8s 'service')

I think we can consider command shortcuts but I would do it one step after the other. @navidshaikh would you mind to open an extra issue for this ? There we could also collect the possible shortcuts (like also src for source ...)

@mattmoor
Copy link
Member Author

To chime in on shortnames, muscle memory would have me typing ksvc, which is how we alias it in kubectl 😇

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2020
@rhuss
Copy link
Contributor

rhuss commented Nov 10, 2020

Fixed with 0.18

@rhuss rhuss closed this as completed Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants