Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

superfluous new lines in some code blocks #2068

Closed
ahmetb opened this issue Dec 19, 2019 · 5 comments · Fixed by knative/website#289
Closed

superfluous new lines in some code blocks #2068

ahmetb opened this issue Dec 19, 2019 · 5 comments · Fixed by knative/website#289
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/cli lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. status/blocked

Comments

@ahmetb
Copy link
Contributor

ahmetb commented Dec 19, 2019

Code blocks in https://knative.dev/docs/serving/accessing-traces/ page have trailing new line

image

@ahmetb ahmetb added the kind/bug Categorizes issue or PR as related to a bug. label Dec 19, 2019
@ahmetb
Copy link
Contributor Author

ahmetb commented Dec 19, 2019

@samodell samodell added this to the Backlog milestone Jan 14, 2020
@mpetason
Copy link
Contributor

mpetason commented Mar 10, 2020

Most of the docs look like this were shell is used:

```shell
kubectl proxy
```

To get it to show up without the extra spacing other sections use:

```
scale-to-zero-grace-period: "30s"
```

I think either we would have to change all of the shell blocks and use , or leave it as is since most of the shell blocks match.

Any ideas?

@abrennan89 abrennan89 modified the milestones: Backlog, Icebox May 20, 2020
@abrennan89 abrennan89 added kind/enhancement lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 20, 2020
@abrennan89 abrennan89 modified the milestones: Icebox, 0.17 docs release Jul 13, 2020
@abrennan89 abrennan89 added kind/meta Documentation about the repo -- contributor roles, issue templates, etc. priority/high and removed priority/nice-to-have size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 13, 2020
@abrennan89
Copy link
Contributor

@mpetason agreed, I think this is a larger question about whether or not we use fenced code blocks. Let's take it to a WG call and figure it out before we tackle this. We should do a review of the whole site to make this consistent once we've decided a style.

@abrennan89 abrennan89 removed this from the v0.17.0 milestone Jan 5, 2021
@abrennan89 abrennan89 added cherrypick-0.16 and removed kind/bug Categorizes issue or PR as related to a bug. kind/meta Documentation about the repo -- contributor roles, issue templates, etc. kind/sample lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/high labels Jan 5, 2021
@abrennan89 abrennan89 added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/cli kind/good-first-issue Denotes an issue ready for a new contributor. priority/critical labels Jan 5, 2021
@abrennan89 abrennan89 added this to the Backlog milestone Jan 25, 2021
@abrennan89 abrennan89 added kind/question lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. status/blocked and removed help wanted kind/good-first-issue Denotes an issue ready for a new contributor. labels Feb 17, 2021
@abrennan89 abrennan89 removed this from the Backlog milestone Feb 17, 2021
@evankanderson
Copy link
Member

evankanderson commented Mar 23, 2021

This seems to be something about the <pre wrapping the <code that introduces an extra 15 pixels (per Developer tools)

<pre style="background-color:#f8f8f8;-moz-tab-size:4;-o-tab-size:4;tab-size:4"><code class="language-shell" data-lang="shell">kubectl label kservice <span style="color:#4e9a06">${</span><span style="color:#000">KSVC_NAME</span><span style="color:#4e9a06">}</span> networking.knative.dev/visibility<span style="color:#ce5c00;font-weight:bold">=</span>cluster-local
</code></pre>

@RichieEscarez
Copy link
Contributor

Not sure what the cause is but the syntax highlighting configuration is here that you might be able to play with and fix/remove the extra line: https://gohugo.io/content-management/syntax-highlighting/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/cli lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. status/blocked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants