-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overlay scroll disable #13
Comments
Sorry for inactivity, due to busy time I cannot investigate issue. Please wait or somehow investigate yourself. |
Hi @rikusen0335 , For now. Once the reference needs to scroll down(now it automatically) to view the entire coach mark screen. Seem it does not work correctly by the position. Can you check this issue? |
Sorry, I couldn't get what are you talking about, could you make an example gif that describe the issue or tell me more context. |
@rikusen0335 sorry for missing that. I think we should have more of a prop like const scrollElement = props.scrollElement
? document.querySelector(props.scrollElement)
: window;
useEffect(() => {
if (!(props.activate && props.element)) return;
props.element?.scrollIntoView({ behavior: 'smooth', block: 'center' });
dimensionSetter({ element: props.element, setDimension });
const scrollEvent = () =>
debounce(dimensionSetter, 300)({ element: props.element, setDimension });
if (!scrollElement) return;
scrollElement.addEventListener('scroll', scrollEvent);
scrollElement.addEventListener('resize', scrollEvent);
return () => {
scrollElement.removeEventListener('scroll', scrollEvent);
scrollElement.removeEventListener('resize', scrollEvent);
};
}, [props.activate, props.element, scrollElement]); |
What is current actual behavior? |
The overlay doesn't disable the scroll on other components of the screen. How should i do that?
The text was updated successfully, but these errors were encountered: