Library doesn't work. Demo is broken.

[vivek-kandhvar]

Did anyone get this to work?

[rikusen0335]

I'll look over it. Wait for a minute

[rikusen0335]

Sorry I have no enough time to investigate.
I can respond in like ~2days, so you could open PR and I'll review.

Or just wait for a time I investigate.

[vivek-kandhvar]

Quick check revealed, reference passed in the prop is null here in this line

[vivek-kandhvar]

@rikusen0335 Did you get a chance at all?

[rikusen0335]

@vivek-kandhvar No, I could check it a bit time, but still in busy now. Sorry.

[rikusen0335]

Hey! Sorry for pasting long time, but I made demo to work as expected now (a bit weird behaviour is still there)

Please give it a try with this branch: https://github.com/knowingharsh/react-coach-mark/tree/refactor-demo
This is just really experimental, please care about that.

[rikusen0335]

So the point is useEffect in pages/DemoOnePage.tsx, that doing like "watch" props which is like really bad behavior, I will investigate deep in deep in the future.

Also at this issue, some linter will warn you that like rerender must be in dependencies but please ignore it. If you are using vscode or like that codeActionsOnSave, use Cmd+K S to save it without formatting and lintering.

Take a look at this in detail: microsoft/vscode#38695 (comment)

[rikusen0335]

@gollumnima if you still looking at this lib

[rikusen0335]

FYI I forgot to push changes. It should be fine now.