Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bitflags traits re-exported #923

Open
vic1707 opened this issue Jan 14, 2025 · 2 comments
Open

Make bitflags traits re-exported #923

vic1707 opened this issue Jan 14, 2025 · 2 comments

Comments

@vic1707
Copy link

vic1707 commented Jan 14, 2025

I'm using the defmt::bitflags! macro and its awesome that you provide a wrapper (was struggling to write the Format impl manually 😓).

I'd like to be able to re-use the exported traits (Bits, Flags) from bitflags without installing it for that sole purpose as it could cause issues by having 2 different versions.
@vic1707
Copy link
Author

vic1707 commented Jan 14, 2025

Note: this issue could be concerned by #877 and other discussions on bitflags v1 vs v2

@vic1707
Copy link
Author

vic1707 commented Jan 15, 2025 •
edited
Loading

Just found out these traits are only available in bitflags v2, in v1 the traits are declared and implemented for each struct.

@vic1707 vic1707 mentioned this issue Jan 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vic1707