You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ko-built images contain Go-built binaries, which embed build information like what commit the binary was built at (which is good!). However, this means that terraform plans that include ko-built images also emit diffs when the commit changes (this is less good).
For example, git rebaseing some code and terraform planning shows this:
This isn't terribly helpful, since I don't know if applying this change will roll out massive breaking code changes or just tiny things picked up by the rebase.
I wonder if there's any way to better express the code/image diff that this Terraform diff is communicating. I don't want a full git diff between the commits (or maybe I do?), but if there was way to print a summary of changes that could be cool.
Practically speaking, maybe the ko_image resource could have a field for the corresponding embedded Go binary build information (e.g., vcs.revision), which would show up in the lower section.
This would probably mean we need ko_images to be "updated" instead of "created" each time, and I'm not sure if that's a bad idea for some reason. We'd also need to do a ko build(+publish?) before we'd be able to surface that diff, so we don't just see (known after apply). That makes terraform planning slower, but hopefully not too slow.
This is mostly a tracking issue to gather ideas and find out what's (im)possible.
The text was updated successfully, but these errors were encountered:
ko
-built images contain Go-built binaries, which embed build information like what commit the binary was built at (which is good!). However, this means that terraform plans that includeko
-built images also emit diffs when the commit changes (this is less good).For example,
git rebase
ing some code andterraform plan
ning shows this:This isn't terribly helpful, since I don't know if
apply
ing this change will roll out massive breaking code changes or just tiny things picked up by the rebase.I wonder if there's any way to better express the code/image diff that this Terraform diff is communicating. I don't want a full
git diff
between the commits (or maybe I do?), but if there was way to print a summary of changes that could be cool.Practically speaking, maybe the
ko_image
resource could have a field for the corresponding embedded Go binary build information (e.g.,vcs.revision
), which would show up in the lower section.This would probably mean we need
ko_image
s to be "updated" instead of "created" each time, and I'm not sure if that's a bad idea for some reason. We'd also need to do ako
build(+publish?) before we'd be able to surface that diff, so we don't just see(known after apply)
. That makesterraform plan
ning slower, but hopefully not too slow.This is mostly a tracking issue to gather ideas and find out what's (im)possible.
The text was updated successfully, but these errors were encountered: