Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] koa-router and @koa/router are on different versions of path-to-regex #192

Open
bizob2828 opened this issue Sep 18, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@bizob2828
Copy link

bizob2828 commented Sep 18, 2024

Describe the bug

I'm on the New Relic Node.js agent team and there was a release of [email protected] this week that broke some of our tests. We fixed them because path-to-regex was upgraded to 8.x. However last night @koa/router released 13.1.0 and the path-to-regex package was reverted to 6.x. I thought these packages were supposed to be identical. We can totally handle this nuance but jsut wanted to get confirmation from you all if this was intended?

@bizob2828 bizob2828 added the bug Something isn't working label Sep 18, 2024
@bizob2828 bizob2828 changed the title [fix] koa-router and @koa/router are on different versions and different versions of path-to-regex [fix] koa-router and @koa/router are on different versions of path-to-regex Sep 18, 2024
@3imed-jaberi 3imed-jaberi self-assigned this Sep 18, 2024
@3imed-jaberi
Copy link
Member

We are reverting path-to-regex from version 8 to version 6 due to the challenges and significant impacts that version 8 poses for many consumers. We are not yet prepared to provide guidance or support for this transition. We plan to address this in a future major release, likely version 14.

Note: The bump to version 8 occurred due to a typo.

About the koa-router, I am waiting to get access to be able to publish these versions: 12.0.2 & 13.1.0.

Koa Router Version Path to Regex Version Koa Router Status
12.0.1 6.2.x Deprecated ❌
12.0.2+ 6.3.0+ Not Deprecated ✅
13.0.0 6.2.x Deprecated ❌
13.0.1 8.x.x Deprecated ❌
13.1.0+ 6.3.0+ Not Deprecated ✅
14.x.x 8.x.x Soon ⏳ ...

cc @titanism

@MatXSz
Copy link

MatXSz commented Sep 26, 2024

Hi, thanks 3imed-jaberi for the informations.
Can you tell when the newer versions of koa-router 12.0.2 and 13.1.0 with Path to Regex 6.3.0+ will be published?

@3imed-jaberi
Copy link
Member

3imed-jaberi commented Sep 26, 2024

@MatXSz I am waiting for the permission. Currently, you can use @koa/router!

cc @titanism

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants