SC2156

Injecting filenames is fragile and insecure. Use parameters.

Problematic code:

find . -name '*.mp3' -exec sh -c 'i="{}"; sox "$i" "${i%.mp3}.wav"' \;

Correct code:

find . -name '*.mp3' -exec sh -c 'i="$1"; sox "$i" "${i%.mp3}.wav"' shell {} \;

Rationale:

In the problematic example, the filename is passed by injecting it into a shell string. Any shell metacharacters in the filename will be interpreted as part of the script, and not as part of the filename. This can break the script and allow arbitrary code execution exploits.

In the correct example, the filename is passed as a parameter. It will be safely treated as literal text. Note that when using shell command with -c, the first parameter to the shell command (in the example "shell") becomes $0 in the shell command's environment, where it is used e.g. in shell error messages (you can set it to an arbitrary value, but it makes sense to set it to the shell's name). You should not use the first parameter to the shell command as data processing parameter, because you could not access $0 e.g. via $* in the shell command (because $* starts with $1), and as said, $0 is used in the shell command's error messages, what would be confusing.

Exceptions:

None.