Include episode part and year #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emveepee This PR needs a proper rebase to the upstream Piers branch. |
@ksooo I know for the EpisodePart PR I wanted an artificact for anyone who needed one but I couldn't figure out how to get good rebase without all that kruft. Figured it out I today, I was rebasing against master. Do you want me to add a test with no episode name and no series number but with the episode number and part? |
Yes, please. The more "tests" the better. |
Add SetEpisodePartNumber() to EPG, add SetYear() to Recordings and EPG.
Add EpisodePart to recordings for API 9
ksooo
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few available tags where not implemented for testing. Update program and test file. Port of #155 which can be canceled.