Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address inconsistent filenames in converter/converters #185

Open
ublubu opened this issue Dec 27, 2017 · 0 comments
Open

address inconsistent filenames in converter/converters #185

ublubu opened this issue Dec 27, 2017 · 0 comments

Comments

@ublubu
Copy link
Contributor

ublubu commented Dec 27, 2017

I think the standard should be koki_<resource>_to_kube.go and kube_<resource>_to_koki.go.

  • It's redundant to have <resource> in the filename twice.
  • Each converter file handles all versions of the resource, so v1 etc isn't needed.
  • The filename needs to specify which direction it implements. koki -> kube vs kube -> koki
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ublubu