Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynRankView: Fix resize and realloc #303

Closed
ndellingwood opened this issue May 26, 2016 · 2 comments
Closed

DynRankView: Fix resize and realloc #303

ndellingwood opened this issue May 26, 2016 · 2 comments
Assignees
@ndellingwood
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Milestone
Summer 2016

Comments

@ndellingwood
Copy link
Contributor

resize and realloc have default dimension arguments set to 0 rather than ~size_t(0).
@ndellingwood ndellingwood added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label May 26, 2016
@ndellingwood ndellingwood added this to the Spring 2016 milestone May 26, 2016
@ndellingwood ndellingwood self-assigned this May 26, 2016
@ndellingwood
Copy link
Contributor Author

Made the necessary fixes for resize and realloc, added unit test, testing now.

@ndellingwood
Copy link
Contributor Author

Also fixed DynRankView Ctor for ViewAllocateWithoutInitializing.
Tested with gcc/4.9 cuda/7.5.18 intel/16.0.1 clang/3.6.1

Pull request to develop #304

@ndellingwood ndellingwood modified the milestones: Summer 2016, Spring 2016 Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndellingwood ndellingwood

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
Summer 2016
Development

No branches or pull requests
1 participant
@ndellingwood