Apply [[noreturn]] to Kokkos::abort when applicable

[AndrewGaspar]

I haven't run any tests beyond just building. Pushing to run CI.

I removed the __APPLE__ check for cuda_abort since I don't think macOS supports CUDA in recent versions anyway. I can put it back if this configuration is still supported, though.

[dalg24-jenkins]

Can one of the admins verify this patch?

[dalg24]

OK to test

[masterleinad]

I removed the __APPLE__ check for cuda_abort since I don't think macOS supports CUDA in recent versions anyway. I can put it back if this configuration is still supported, though.

I would say it does at least for CUDA versions we support: https://www.nvidia.com/en-us/drivers/cuda/418_163/macosx-cuda-418_163-driver/ and assert() is not supported on MacOS at least in 9.0 https://docs.nvidia.com/cuda/archive/9.0/cuda-c-programming-guide/index.html#assertion.

[AndrewGaspar]

OK, if people are still using CUDA on Mac, then I'll put it back.

[dhollman]

we use the KOKKOS_IMPL_ prefix in macros where we're not going to guarantee stability for users, which is probably the case here, at least at first (we can always add #define KOKKOS_ABORT_NORETURN KOKKOS_IMPL_ABORT_NORETURN later if we change our minds)

Otherwise, thanks! Looks good.

[masterleinad]

Retest this please.

[crtrott]

Retest This Please

[masterleinad]

This changed recently, see

kokkos/core/src/HIP/Kokkos_HIP_Abort.hpp

Lines 56 to 63 in 89e9d26

	__device__ __attribute__((noinline)) void hip_abort(char const *msg) {
	#ifndef NDEBUG
	// disable printf on release builds, as it has a non-trivial performance
	// impact
	printf("Aborting with message `%s'.\n", msg);
	#endif
	abort();
	}

[crtrott]

oh man. I was about to merge it :-(

[masterleinad]

I would be fine with addressing that in a follow-up pull request.

[masterleinad]

I am currently seeing

/tmp/kokkos/core/src/HIP/Kokkos_HIP_Abort.hpp:64:1: warning: function declared 'noreturn' should not return [-Winvalid-noreturn]

if trying to mark the function with [[noreturn]] so we might just postpone fixing it.

[dhollman]

LGTM