Skip to content

Commit

Permalink
🔧 Allow binary arguments via helm chart (#201)
Browse files Browse the repository at this point in the history
This commit allows to pass arguments to the helm chart.
This is useful if you want to specify arguments for the
helm-dashboard binary whilst deploying via helm.
  • Loading branch information
toddtee authored Jan 26, 2023
1 parent 23cfd2d commit 7e32008
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 0 deletions.
1 change: 1 addition & 0 deletions charts/helm-dashboard/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ The following table lists the configurable parameters of the chart and their def
| `dashboard.persistence.size` | Persistent Volume size | `100M` |
| `dashboard.persistence.hostPath` | Set path in case you want to use local host path volumes (not recommended in production) | `""`
| `updateStrategy.type` | Set up update strategy for helm-dashboard installation. | `RollingUpdate` |
| `extraArgs` | Set the arguments to be supplied to the helm-dashboard binary | `[--no-browser, --bind=0.0.0.0]`

Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`.

Expand Down
6 changes: 6 additions & 0 deletions charts/helm-dashboard/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ spec:
{{- toYaml .Values.podSecurityContext | nindent 8 }}
containers:
- name: {{ .Chart.Name }}
command:
- /bin/helm-dashboard
args:
{{- with .Values.extraArgs }}
{{- toYaml . | nindent 12 }}
{{- end }}
securityContext:
{{- toYaml .Values.securityContext | nindent 12 }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
Expand Down
4 changes: 4 additions & 0 deletions charts/helm-dashboard/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,10 @@ autoscaling:

nodeSelector: {}

extraArgs:
- --no-browser
- --bind=0.0.0.0

tolerations: []

affinity: {}
Expand Down

0 comments on commit 7e32008

Please sign in to comment.