Overwrite old values correctly, don't cache current resources list

komodorio · Feb 21, 2023 · a7c7ba8 · a7c7ba8
1 parent d86c46a
commit a7c7ba8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/charts/helm-dashboard/README.md b/charts/helm-dashboard/README.md
@@ -5,7 +5,7 @@
 ```bash
 helm repo add komodorio https://helm-charts.komodor.io
 helm repo update
-helm upgrade --install my-release komodorio/helm-dashboard
+helm upgrade --install helm-dashboard komodorio/helm-dashboard
 ```
 
 ## Introduction
@@ -17,14 +17,13 @@ While installed inside cluster, Helm Dashboard will run some additional backgrou
 ## Prerequisites
 
 - Kubernetes 1.16+
-- Helm 3+
 
 ## Installing the Chart
 
-To install the chart with the release name `my-release`:
+To install the chart with the release name `helm-dashboard`:
 
 ```bash
-helm install my-release .
+helm install helm-dashboard .
 ```
 
 The command deploys Helm Dashboard on the Kubernetes cluster in the default configuration. The [Parameters](#parameters) section lists the parameters that can be configured during installation.
@@ -33,10 +32,10 @@ The command deploys Helm Dashboard on the Kubernetes cluster in the default conf
 
 ## Uninstalling the Chart
 
-To uninstall/delete the `my-release` deployment:
+To uninstall/delete the `helm-dashboard` deployment:
 
 ```bash
-helm uninstall my-release
+helm uninstall helm-dashboard
 ```
 
 The command removes all the Kubernetes components associated with the chart and deletes the release.
@@ -80,7 +79,7 @@ The following table lists the configurable parameters of the chart and their def
 Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`.
 
 ```bash
-helm upgrade --install my-release komodorio/helm-dashboard --set dashboard.allowWriteActions=true --set service.port=9090
+helm upgrade --install helm-dashboard komodorio/helm-dashboard --set dashboard.allowWriteActions=true --set service.port=9090
 ```
 
 > **Tip**: You can use the default [values.yaml](values.yaml)
diff --git a/pkg/dashboard/handlers/helmHandlers.go b/pkg/dashboard/handlers/helmHandlers.go
@@ -121,7 +121,7 @@ func (h *HelmHandler) History(c *gin.Context) {
 }
 
 func (h *HelmHandler) Resources(c *gin.Context) {
-	h.EnableClientCache(c)
+	// can't enable the client cache because resource list changes with time
 
 	rel := h.getRelease(c)
 	if rel == nil {

diff --git a/pkg/dashboard/objects/releases.go b/pkg/dashboard/objects/releases.go
@@ -320,6 +320,7 @@ func (r *Release) Upgrade(repoChart string, version string, justTemplate bool, v
 	cmd.Version = version
 
 	cmd.DryRun = justTemplate
+	cmd.ResetValues = true
 
 	chrt, err := locateChart(cmd.ChartPathOptions, repoChart, r.Settings)
 	if err != nil {