Shut down modal #281
Merged
Shut down modal #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chad11111 please have a look. |
chad11111
approved these changes
Mar 21, 2023
dashboard/src/layout/Header.tsx
Outdated
| return ( | ||
| <header className="app-header"> | ||
| { | ||
| signOut && <SignOutpopup/> |
There was a problem hiding this comment.
please use the popup component.
There was a problem hiding this comment.
@chad11111 for that i would need to install the reactjs-popup dependency do you want me to do this way?
There was a problem hiding this comment.
No, don't install anything we wrote our own modal.
Have a look here.
https://github.com/komodorio/helm-dashboard/tree/helm-dashboard-v2/dashboard/src/components/modal
dashboard/package.json
Outdated
| @@ -4,9 +4,13 @@ | |||
| "description": "", | |||
| "main": "index.js", | |||
| "dependencies": { | |||
| "@emotion/react": "^11.10.6", | |||
dashboard/package.json
Outdated
| @@ -4,9 +4,13 @@ | |||
| "description": "", | |||
| "main": "index.js", | |||
| "dependencies": { | |||
| "@emotion/react": "^11.10.6", | |||
| "@emotion/styled": "^11.10.6", | |||
There was a problem hiding this comment.
@chad11111 i used material-ui for the icon so for that i needed to install these
There was a problem hiding this comment.
can u use this https://react-icons.github.io/react-icons/?
dashboard/package.json
Outdated
| "@emotion/react": "^11.10.6", | ||
| "@emotion/styled": "^11.10.6", | ||
| "@mui/icons-material": "^5.11.11", | ||
| "@mui/material": "^5.11.13", |
There was a problem hiding this comment.
do we need this ? cant we just use icons ?
There was a problem hiding this comment.
@chad11111 i'll try to check with icons i am not sure about that. i am comfortable with material-ui and its a bit more styled but if you want me to do with icons i'll look into it.
There was a problem hiding this comment.
We dont want to use mui.
Please only use the icons.
|
@aman1376 You have some conflicts :( sorry about that. |
feat - liner
* Update README Componenet library section * Update dashboard/README.md --------- Co-authored-by: chad11111 <[email protected]>
* Status Element * added status and button * Added revisionCard, and conditional rendering for version upgrade/downgrade and time since revision started. * adding all changes before push * Revisioning of revision card and of status * Added refresh button to revision card * Adding tabbar * Extracted age logic in revisioncard component * trying to get storybook to work and adding comments to revision card getRevisionAgeJSX auxiliary function. * Configured storybook with a few samples * Added info in Revision Card story, and showcased special badged. * Added a special button example in storybook * Easy Entry for storybook * Response to review. extracted revisioncard props into an interface and created global.tsx for global types. Added textinput.tsx and a story to display it. * Removed unecessary css import. * Corrected stories to enable passing interface props. * refactored statuscode in Status.tsx * Fixed props passing bug. * Extracted getAge to timeUtils. * Fixed BadgeProps * Refactored stories. * fixed bug in timeUtils.tsx * Fixed problem with storybook. Now comps are showing. * Reduced weird bloated package.json and made sure story-book still works.
* Increment chart versions [skip ci] * Minor UI fixes (komodorio#234) * Add username and password support to Repo add feature (komodorio#228) * Add username and password support to Repo add in UI * Add support for Username and Passowrd in Add Repo API * Display resource health aggregate icons on list of releases (komodorio#235) * Display aggregate resource health status * Reuse old API request, show icons * Take progress indication from deployment conditions * Improve status * Cleanup * Fixups * Squares approach * Improve console message in case no k8s connection possible * Count API docs in user analytics * Create first Generic Modal + add storybook script * change default modal button style * Create anum for button styles * fix type in console log * Make the title completely customizable * change story name * Make the title optional * implement auto scroll when height bigger than 500 * fix story example * Change buttons in modal stories * fix type * Revert "Merge branch 'komodorio:main' into create-an-empty-global-modal" This reverts commit e6aae0b, reversing changes made to e37c6fe. * Add className prop for fully customization * Change buttonStyle to variant * add id to ModalAction * Add modal to portal div * Add background with opacity * change from type to interface * fix modal margin * Add it for the modal storybook --------- Co-authored-by: komodor-bot <[email protected]> Co-authored-by: Harshit Mehta <[email protected]> Co-authored-by: Andrey Pokhilko <[email protected]>
* skeleton for helm-dashboard-v2 * made-necessary changes
…dashboard into helm-dashboard-v2
…-dashboard into helm-dashboard-v2
|
@chad11111 pls have a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed
Created a popup when the shut down button is clicked.
Check List